From: Timm Bäder <mail@baedert.org>
Date: Thu, 22 Aug 2019 10:14:33 +0000 (+0200)
Subject: cssstaticstyle: Avoid ref'ing specified value in compute_value
X-Git-Tag: archive/raspbian/4.4.1+ds1-2+rpi1~1^2~321^2^2~959
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f3fdf58ff795213832e311ea5d40c4e074d54609;p=gtk4.git

cssstaticstyle: Avoid ref'ing specified value in compute_value

There are alerady _get functions for GtkCssInheritValue and
GtkCssInitialValue, so use those. We can avoid a ref+unref pair this
way.
---

diff --git a/gtk/gtkcssstaticstyle.c b/gtk/gtkcssstaticstyle.c
index 7f7eba14ab..f2e0b1db16 100644
--- a/gtk/gtkcssstaticstyle.c
+++ b/gtk/gtkcssstaticstyle.c
@@ -219,19 +219,14 @@ gtk_css_static_style_compute_value (GtkCssStaticStyle *style,
       GtkCssStyleProperty *prop = _gtk_css_style_property_lookup_by_id (id);
 
       if (_gtk_css_style_property_is_inherit (prop))
-        specified = _gtk_css_inherit_value_new ();
+        specified = _gtk_css_inherit_value_get ();
       else
-        specified = _gtk_css_initial_value_new ();
+        specified = _gtk_css_initial_value_get ();
     }
-  else
-    _gtk_css_value_ref (specified);
 
   value = _gtk_css_value_compute (specified, id, provider, (GtkCssStyle *)style, parent_style);
 
   gtk_css_static_style_set_value (style, id, value, section);
-  value = NULL;
-
-  _gtk_css_value_unref (specified);
 }
 
 GtkCssChange